Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| plugins: { | ||
| decimation: { | ||
| enabled: true, | ||
| algorithm: 'lttb', | ||
| samples: 2000, | ||
| threshold: 4000 |
There was a problem hiding this comment.
Decimation mutates data used for export and hover sync
Enabling the Chart.js decimation plugin here replaces each dataset’s data array with a ~2000-point LTTB sample whenever a series exceeds the 4k threshold. The rest of ChartContainer relies on chart.data.datasets for features like exportChartCSV and cross-chart hover sync, so large logs will now export only the decimated subset and most steps will no longer synchronize between charts because the searched x-values were removed during downsampling. Consider using the original data (_data/parsedData) for these operations or disabling decimation when exporting/syncing to avoid losing points.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task